Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
S
SiB Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 110
    • Issues 110
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Startin blox
  • framework
  • SiB Core
  • Merge Requests
  • !307

Merged
Opened Jan 15, 2020 by Matthieu Fesselier@matthieu
  • Report abuse
Report abuse

feature: add map capabilities

Closes: #560 (closed) #561 (closed)

As these 2 features were very linked, I added both on the same branch. However, there is one commit for each if you want to inspect what does what.

To test, you can check the examples used by cypress in examples/e2e/solid-map.html and play with the attributes in an HTML file. Don't hesitate to tell if you find the tests not sufficient.

About the choices I made:

  • I included by default the CSS file. I'm open to discussion but the user won't see anything if it's not included, so I think this is easier for him
  • On the contrary of a sib-display, if you don't put a fields attribute, it does not display the marker popup. Like this, we keep the old map behavior, and just add capabilities

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feature/560-groupby-map" "origin/feature/560-groupby-map"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/dev"
git merge --no-ff "feature/560-groupby-map"

Step 4. Push the result of the merge to GitLab

git push origin "dev"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 4
  • Commits 3
  • Pipelines 3
  • Changes 13
Assignee
Assign to
0.10
Milestone
0.10
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: startinblox/framework/sib-core!307